[
https://issues.apache.org/jira/browse/BEAM-12544?focusedWorklogId=615296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-615296
]
ASF GitHub Bot logged work on BEAM-12544:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/21 07:47
Start Date: 26/Jun/21 07:47
Worklog Time Spent: 10m
Work Description: Dobiasd commented on a change in pull request #15087:
URL: https://github.com/apache/beam/pull/15087#discussion_r659135263
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java
##########
@@ -765,8 +765,8 @@ private void readObject(ObjectInputStream in) throws
IOException, ClassNotFoundE
if (logicalType instanceof LogicalTypes.Decimal) {
fieldType = FieldType.DECIMAL;
} else if (logicalType instanceof LogicalTypes.TimestampMillis) {
- // TODO: There is a desire to move Beam schema DATETIME to a micros
representation. When
Review comment:
This is unrelated to the representation of Beam schema `DATETIME`. The
correct TODO comment for this is here:
https://github.com/apache/beam/blob/961cf0936d7065bf6089e666fbbc6b83da266df2/sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AvroUtils.java#L883-L884
So the comment here can (and should) be removed, even independently of the
change in this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 615296)
Time Spent: 0.5h (was: 20m)
> Add support for Avro timestamps in microseconds
> -----------------------------------------------
>
> Key: BEAM-12544
> URL: https://issues.apache.org/jira/browse/BEAM-12544
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Affects Versions: Not applicable
> Reporter: Tobias Hermann
> Priority: P2
> Fix For: Not applicable
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> GenericRecordToRowFn in AvroUtils does not support the logical Avro type
> "timestamp-micros". Instead of converting it to FieldType.DATETIME (as it
> does with "timestamp-millis") it just interprets it as a raw LONG.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
