[
https://issues.apache.org/jira/browse/BEAM-12541?focusedWorklogId=616167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-616167
]
ASF GitHub Bot logged work on BEAM-12541:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/21 13:20
Start Date: 29/Jun/21 13:20
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #15086:
URL: https://github.com/apache/beam/pull/15086#issuecomment-868832021
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15086?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15086](https://codecov.io/gh/apache/beam/pull/15086?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(ad7e0b3) into
[master](https://codecov.io/gh/apache/beam/commit/f6735ee343fda1dadada5b49c14946968336852b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(f6735ee) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/15086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15086 +/- ##
=======================================
Coverage 83.76% 83.77%
=======================================
Files 439 439
Lines 59187 59199 +12
=======================================
+ Hits 49577 49591 +14
+ Misses 9610 9608 -2
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15086?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/dataframe/frames.py](https://codecov.io/gh/apache/beam/pull/15086/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vZGF0YWZyYW1lL2ZyYW1lcy5weQ==)
| `94.44% <100.00%> (+0.09%)` | :arrow_up: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/15086/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `86.17% <0.00%> (-1.07%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/15086/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `90.90% <0.00%> (-0.31%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15086/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `88.85% <0.00%> (+0.45%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15086?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15086?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[f6735ee...ad7e0b3](https://codecov.io/gh/apache/beam/pull/15086?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 616167)
Time Spent: 2h 20m (was: 2h 10m)
> fillna(value=DataFrame/Series) does not correctly fill values
> -------------------------------------------------------------
>
> Key: BEAM-12541
> URL: https://issues.apache.org/jira/browse/BEAM-12541
> Project: Beam
> Issue Type: Bug
> Components: dsl-dataframe
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: P2
> Fix For: 2.32.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> A new doctest was added in 1.3.0 that verifies fillna with a DataFrame value:
> {code}
> df = pd.DataFrame([[np.nan, 2, np.nan, 0],
> [3, 4, np.nan, 1],
> [np.nan, np.nan, np.nan, 5],
> [np.nan, 3, np.nan, 4]],
> columns=list("ABCD"))
> df2 = pd.DataFrame(np.zeros((4, 4)), columns=list("ABCE"))
> df.fillna(df2)
> A B C D
> 0 0.0 2.0 0.0 0
> 1 3.0 4.0 0.0 1
> 2 0.0 0.0 0.0 5
> 3 0.0 3.0 0.0 4
> {code}
> Unfortunately, we fail this test. The root cause is that we don't require
> Index partitioning when fillna is called with a DataFrame/Series value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
