[
https://issues.apache.org/jira/browse/BEAM-12547?focusedWorklogId=616525&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-616525
]
ASF GitHub Bot logged work on BEAM-12547:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/21 14:40
Start Date: 29/Jun/21 14:40
Worklog Time Spent: 10m
Work Description: suztomo commented on a change in pull request #15091:
URL: https://github.com/apache/beam/pull/15091#discussion_r660686255
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy
##########
@@ -49,7 +49,7 @@ class GrpcVendoring_1_36_0 {
"io.grpc:grpc-netty:$grpc_version",
"io.grpc:grpc-protobuf:$grpc_version",
"io.grpc:grpc-stub:$grpc_version",
- "io.netty:netty-transport-native-epoll:$netty_version",
+ "io.netty:netty-transport-native-epoll:$netty_version:linux-x86_64",
Review comment:
Would you add comment why it's ok to limit this to linux-x86_64?
(Or wasn't it working at all without classifier?
https://netty.io/wiki/native-transports.html says
`<classifier>linux-x86_64</classifier>`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 616525)
Time Spent: 1h 50m (was: 1h 40m)
> Fix epoll shading in vendored gRPC
> ----------------------------------
>
> Key: BEAM-12547
> URL: https://issues.apache.org/jira/browse/BEAM-12547
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> ManagedChannelFactoryTest is always skipping the Epoll tests since the
> tcnative epoll shading was broken.
> Steps are:
> 1) Fix shading
> 2) Release minor version bump for shaded gRPC
> 3) Consume minor version bump and make the tests required if using linux arch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
