[
https://issues.apache.org/jira/browse/BEAM-11996?focusedWorklogId=616589&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-616589
]
ASF GitHub Bot logged work on BEAM-11996:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/21 16:21
Start Date: 29/Jun/21 16:21
Worklog Time Spent: 10m
Work Description: MiguelAnzoWizeline commented on a change in pull
request #14811:
URL: https://github.com/apache/beam/pull/14811#discussion_r660775497
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java
##########
@@ -73,18 +74,16 @@ public static BatchSpannerRead create(
.apply(
"Generate Partitions",
ParDo.of(new GeneratePartitionsFn(getSpannerConfig(),
txView)).withSideInputs(txView))
- .apply("Shuffle partitions", Reshuffle.<Partition>viaRandomKey())
.apply(
"Read from Partitions",
ParDo.of(new ReadFromPartitionFn(getSpannerConfig(),
txView)).withSideInputs(txView));
}
@VisibleForTesting
- static class GeneratePartitionsFn extends DoFn<ReadOperation, Partition> {
+ static class GeneratePartitionsFn extends DoFn<ReadOperation,
List<Partition>> {
Review comment:
Added TODO message to GeneratePartitionsFn mentioning it should be
integrated into ReadFromPartitionFn when the issue is solved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 616589)
Time Spent: 4h (was: 3h 50m)
> Implement SpannerIO on top of Splittable DoFn
> ---------------------------------------------
>
> Key: BEAM-11996
> URL: https://issues.apache.org/jira/browse/BEAM-11996
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Reporter: Boyuan Zhang
> Assignee: Miguel Anzo
> Priority: P2
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
