[
https://issues.apache.org/jira/browse/BEAM-12539?focusedWorklogId=616770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-616770
]
ASF GitHub Bot logged work on BEAM-12539:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/21 22:50
Start Date: 29/Jun/21 22:50
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #15099:
URL: https://github.com/apache/beam/pull/15099#discussion_r661013996
##########
File path: sdks/python/apache_beam/io/kafka.py
##########
@@ -96,8 +96,16 @@
('commit_offset_in_finalize', bool), ('timestamp_policy', str)])
-def default_io_expansion_service():
- return BeamJarExpansionService('sdks:java:io:expansion-service:shadowJar')
+def default_io_expansion_service(args = None):
+ extra_args = None
+ if args:
+ if type(args) != type({}):
Review comment:
`isinstance(args, dict)` otherwise even subclasses are excluded.
Generally Python uses duck typing, so as long as this offers an item method
(whether or not it's actually a dict) we should allow it through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 616770)
Time Spent: 40m (was: 0.5h)
> Python Kafka IO: allow to specify command line arguments for default
> expansion service
> --------------------------------------------------------------------------------------
>
> Key: BEAM-12539
> URL: https://issues.apache.org/jira/browse/BEAM-12539
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Affects Versions: 2.31.0
> Reporter: Jan Lukavský
> Assignee: Jan Lukavský
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> In order to be able to run ExpansionService with specific command line
> arguments we need to be able to specify these arguments when creating read or
> write transform.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
