[
https://issues.apache.org/jira/browse/BEAM-12548?focusedWorklogId=617244&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617244
]
ASF GitHub Bot logged work on BEAM-12548:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/21 19:50
Start Date: 30/Jun/21 19:50
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15110:
URL: https://github.com/apache/beam/pull/15110#discussion_r661765809
##########
File path: sdks/go/pkg/beam/testing/passert/equals.go
##########
@@ -40,6 +40,18 @@ func Equals(s beam.Scope, col beam.PCollection, values
...interface{}) beam.PCol
return equals(subScope, col, other)
}
+// EqualsList verifies that the given collection has the same values as a
+// given list, under coder equality. The values must be provided as an
+// array or slice.
+func EqualsList(s beam.Scope, col beam.PCollection, list interface{})
beam.PCollection {
Review comment:
Consider adding an additional statement saying that this is equivalent
to using a beam.CreateList PCollection as an expected value to Equals.
This does help save a line or two for additional semantic clarity, but
noting the equivalence helps make beam more accessible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617244)
Time Spent: 0.5h (was: 20m)
> [Go SDK] PAssert improvements
> -----------------------------
>
> Key: BEAM-12548
> URL: https://issues.apache.org/jira/browse/BEAM-12548
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Robert Burke
> Assignee: Jack McCluskey
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The Go SDK Passert package could be more helpful.
> It could have GoDoc examples for correct and less clear use of each of the
> functions (like both the variadic and PCollection approaches for
> passert.Equals).
> There could be better/more sophisticated handling for floating point values,
> eg with thresholds.
> There could be special/magic handling for synthetic KV types that could then
> be used for handling Equals against KV PCollections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
