[
https://issues.apache.org/jira/browse/BEAM-12511?focusedWorklogId=617636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617636
]
ASF GitHub Bot logged work on BEAM-12511:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 15:05
Start Date: 01/Jul/21 15:05
Worklog Time Spent: 10m
Work Description: RaphaelSanamyan commented on a change in pull request
#15052:
URL: https://github.com/apache/beam/pull/15052#discussion_r662372325
##########
File path:
sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java
##########
@@ -1353,14 +1236,136 @@ void set(
@Override
public PCollection<Void> expand(PCollection<T> input) {
- checkArgument(getStatement() != null, "withStatement() is required");
+ WriteVoid<T> spec = this;
checkArgument(
- getPreparedStatementSetter() != null, "withPreparedStatementSetter()
is required");
- checkArgument(
- (getDataSourceProviderFn() != null),
+ (spec.getDataSourceProviderFn() != null),
"withDataSourceConfiguration() or withDataSourceProviderFn() is
required");
+ // fixme: validate invalid table input
+ if (input.hasSchema() && !spec.hasStatementAndSetter()) {
Review comment:
Yes, you're right. I moved this part of the code because it will let to
use the class without the statement and at the same time it just extends this
class without breaking compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617636)
Time Spent: 50m (was: 40m)
> JdbcIO.Write.withResults work without statement
> -----------------------------------------------
>
> Key: BEAM-12511
> URL: https://issues.apache.org/jira/browse/BEAM-12511
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jdbc
> Reporter: Sanamyan Raphael
> Assignee: Sanamyan Raphael
> Priority: P2
> Time Spent: 50m
> Remaining Estimate: 0h
>
> JdbcIO.Write can work without statement and preparedStatementSetter in all
> case except using "Write.withResults". e.g.
> {code:java}
> PCollection<Row> dataCollection = pipeline.apply(Create.of(data));
> PCollection<Void> rowsWritten =
> dataCollection.apply(
> JdbcIO.<Row>write()
> .withDataSourceConfiguration(DATA_SOURCE_CONFIGURATION)
> .withBatchSize(10L)
> .withTable(firstTableName)
> .withResults());
> .dataCollection .
> .apply(Wait.on(rowsWritten))
> .apply(
> JdbcIO.<Row>write()
> .withDataSourceConfiguration(DATA_SOURCE_CONFIGURATION)
> .withBatchSize(10L)
> .withTable(secondTableName));
> .run();
> {code}
> Need to add ability to use "Write.withResults" without statement and
> preparedStatementSetter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
