[
https://issues.apache.org/jira/browse/BEAM-5995?focusedWorklogId=207161&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-207161
]
ASF GitHub Bot logged work on BEAM-5995:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/19 14:11
Start Date: 04/Mar/19 14:11
Worklog Time Spent: 10m
Work Description: kkucharc commented on pull request #7808: [BEAM-5995]
Created Jenkins DSL for Python Load Tests
URL: https://github.com/apache/beam/pull/7808#discussion_r262073163
##########
File path: .test-infra/jenkins/CommonTestProperties.groovy
##########
@@ -16,20 +16,44 @@
* limitations under the License.
*/
+
+
class CommonTestProperties {
+ enum SDK {
+ PYTHON,
+ JAVA
+ }
+
enum Runner {
- DATAFLOW("DataflowRunner", ":beam-runners-google-cloud-dataflow-java"),
- SPARK("SparkRunner", ":beam-runners-spark"),
- FLINK("TestFlinkRunner", ":beam-runners-flink_2.11"),
- DIRECT("DirectRunner", ":beam-runners-direct-java")
+ DATAFLOW("DataflowRunner"),
+ SPARK("SparkRunner"),
+ FLINK("TestFlinkRunner"),
+ DIRECT("DirectRunner"),
+
+ def RUNNER_DEPENDENCY_MAP = [
+ JAVA: [
+ DATAFLOW: ":beam-runners-google-cloud-dataflow-java",
+ SPARK: ":beam-runners-spark",
+ FLINK: ":beam-runners-flink_2.11",
+ DIRECT: ":beam-runners-direct-java"
+ ],
+ PYTHON: [
+ DATAFLOW: "TestDataflowRunner",
+ DIRECT: "DirectRunner",
+ ]
+ ]
private final String option
- private final String dependency
- Runner(String option, String dependency) {
+ Runner(String option) {
this.option = option
- this.dependency = dependency
}
+
+
+ String getDepenedencyBySDK(SDK sdk) {
+ RUNNER_DEPENDENCY_MAP.get(sdk.toString()).get(this.toString())
+ }
Review comment:
@lgajowy This is a new implementation using SDK enum to get right dependency
from map. I am no sure only if it's going to be clear for this enum user that
you can use method of an enum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 207161)
Time Spent: 6.5h (was: 6h 20m)
> Create Jenkins jobs to run the load tests
> -----------------------------------------
>
> Key: BEAM-5995
> URL: https://issues.apache.org/jira/browse/BEAM-5995
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Labels: triaged
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
