[ 
https://issues.apache.org/jira/browse/BEAM-3415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17377490#comment-17377490
 ] 

Philip Wilcox edited comment on BEAM-3415 at 7/9/21, 3:12 PM:
--------------------------------------------------------------

I'm curious about what specifically I should be watching out for here / how the 
failures show up. I've been using Junit5+Beam (and TestPipeline)+Gradle without 
issue, including with features like nested tests and parameterized tests, but 
this ticket now causes some concern if there are failures happening for other 
people, in case I just haven't hit the problem cases yet.

 

Gradle 6.8.2

Beam 2.28.0

Junit-Jupiter 5.7.0

Junit-Platform-Engine-1.7.0

 

There are some junit 4 deps showing up in my gradle dependencies output 
transitively, from other things, but looking at the stack in the debugger it 
shows the 5.7.0 stuff in the test run.

 

EDIT: after some more digging we found that if we completely kill the 
transitive junit4 deps, we get a failure on beam using  
org.junit.rules.TestRule in TestPipeline setup, but if we have both junit4 and 
5 in gradle, this is currently working fine. So Which feels potentially dicey 
long term, but hopefully this can get fixed in the Beam side at some point and 
we can drop the old dep.


was (Author: philipwilcox):
I'm curious about what specifically I should be watching out for here / how the 
failures show up. I've been using Junit5+Beam (and TestPipeline)+Gradle without 
issue, including with features like nested tests and parameterized tests, but 
this ticket now causes some concern if there are failures happening for other 
people, in case I just haven't hit the problem cases yet.

 

Gradle 6.8.2

Beam 2.28.0

Junit-Jupiter 5.7.0

Junit-Platform-Engine-1.7.0

 

There are some junit 4 deps showing up in my gradle dependencies output 
transitively, from other things, but looking at the stack in the debugger it 
shows the 5.7.0 stuff in the test run.

> JUnit5 support
> --------------
>
>                 Key: BEAM-3415
>                 URL: https://issues.apache.org/jira/browse/BEAM-3415
>             Project: Beam
>          Issue Type: New Feature
>          Components: testing
>            Reporter: Romain Manni-Bucau
>            Priority: P3
>          Time Spent: 7h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to