[
https://issues.apache.org/jira/browse/BEAM-12611?focusedWorklogId=622358&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-622358
]
ASF GitHub Bot logged work on BEAM-12611:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jul/21 03:37
Start Date: 14/Jul/21 03:37
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #15166:
URL: https://github.com/apache/beam/pull/15166#discussion_r669249778
##########
File path:
sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java
##########
@@ -78,6 +78,7 @@
Review comment:
It is best to write a test rule like
https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/testing/RestoreDataflowLoggingMDC.java
and use it in the test instead of relying on everyone doing the appropriate
clean-up.
There is also a RestoreDataflowLoggingMDCTest.java as well containing unit
tests for the test rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 622358)
Time Spent: 20m (was: 10m)
> Populate instruction id in Java SDK harness log entries
> -------------------------------------------------------
>
> Key: BEAM-12611
> URL: https://issues.apache.org/jira/browse/BEAM-12611
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Alex Amato
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
