[
https://issues.apache.org/jira/browse/BEAM-2914?focusedWorklogId=623334&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623334
]
ASF GitHub Bot logged work on BEAM-2914:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/21 23:53
Start Date: 15/Jul/21 23:53
Worklog Time Spent: 10m
Work Description: y1chi commented on a change in pull request #15137:
URL: https://github.com/apache/beam/pull/15137#discussion_r670875187
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/TimestampPrefixingWindowCoder.java
##########
@@ -67,4 +74,20 @@ public T decode(InputStream inStream) throws CoderException,
IOException {
public void verifyDeterministic() throws NonDeterministicException {
windowCoder.verifyDeterministic();
}
+
+ @Override
+ public boolean consistentWithEquals() {
+ return windowCoder.consistentWithEquals();
+ }
+
+ @Override
+ public boolean isRegisterByteSizeObserverCheap(T value) {
+ return windowCoder.isRegisterByteSizeObserverCheap(value);
+ }
+
+ @Override
+ public void registerByteSizeObserver(T value, ElementByteSizeObserver
observer) throws Exception {
+ InstantCoder.of().registerByteSizeObserver(new Instant(), observer);
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 623334)
Time Spent: 14h 10m (was: 14h)
> Fn API merging window support
> -----------------------------
>
> Key: BEAM-2914
> URL: https://issues.apache.org/jira/browse/BEAM-2914
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Priority: P3
> Labels: portability
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> The Fn API should support merging windows. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
