[
https://issues.apache.org/jira/browse/BEAM-11934?focusedWorklogId=623787&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623787
]
ASF GitHub Bot logged work on BEAM-11934:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/21 18:28
Start Date: 16/Jul/21 18:28
Worklog Time Spent: 10m
Work Description: nehsyc commented on pull request #15178:
URL: https://github.com/apache/beam/pull/15178#issuecomment-881637699
> Do you think we should keep the old behavior as an option in case some
customers run into issues ?
The override was not used because before the introduction of auto sharding,
streaming write was required to specify a fixed number of shards otherwise
fails:
https://github.com/apache/beam/blob/d7eb872576c89abba299ed445075ff593ff556a5/sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java#L319
I forgot to remove the override when I loosed the check to allow runner
determined sharding for unbounded data :\
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 623787)
Time Spent: 5h 10m (was: 5h)
> Dataflow GCS streaming file sink uses runner determined sharding
> ----------------------------------------------------------------
>
> Key: BEAM-11934
> URL: https://issues.apache.org/jira/browse/BEAM-11934
> Project: Beam
> Issue Type: Improvement
> Components: io-java-files, io-java-gcp, runner-dataflow
> Reporter: Siyuan Chen
> Priority: P2
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Integrate file sink with shardable `GroupIntoBatches` (BEAM-10475) to allow
> runner determined dynamic sharding for streaming use cases.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)