[
https://issues.apache.org/jira/browse/BEAM-2914?focusedWorklogId=624659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-624659
]
ASF GitHub Bot logged work on BEAM-2914:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/21 21:27
Start Date: 19/Jul/21 21:27
Worklog Time Spent: 10m
Work Description: y1chi commented on a change in pull request #15137:
URL: https://github.com/apache/beam/pull/15137#discussion_r672643265
##########
File path:
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml
##########
@@ -440,3 +441,25 @@ examples:
shardId: "",
key: "key"
}
+
+---
+
+# Java code snippet to generate example bytes:
+# TimestampPrefixingWindowCoder<IntervalWindow> coder =
TimestampPrefixingWindowCoder.of(IntervalWindowCoder.of());
+# Instant end = new Instant(-9223372036854410L);
+# Duration span = Duration.millis(365L);
+# IntervalWindow window = new IntervalWindow(end.minus(span), span);
+# byte[] bytes = CoderUtils.encodeToByteArray(coder, window);
+# String str = new String(bytes,
java.nio.charset.StandardCharsets.ISO_8859_1);
+# String example = "";
+# for(int i = 0; i < str.length(); i++){
+# example += CharUtils.unicodeEscaped(str.charAt(i));
+# }
+# System.out.println(example);
+coder:
+ urn: "beam:coder:custom_window:v1"
+ components: [{urn: "beam:coder:interval_window:v1"}]
Review comment:
yep, using interval_window coder here makes it easier to verify in
standard coder test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 624659)
Time Spent: 16h 50m (was: 16h 40m)
> Fn API merging window support
> -----------------------------
>
> Key: BEAM-2914
> URL: https://issues.apache.org/jira/browse/BEAM-2914
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Priority: P3
> Labels: portability
> Time Spent: 16h 50m
> Remaining Estimate: 0h
>
> The Fn API should support merging windows. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
