[ 
https://issues.apache.org/jira/browse/BEAM-12665?focusedWorklogId=628283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628283
 ]

ASF GitHub Bot logged work on BEAM-12665:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Jul/21 09:08
            Start Date: 27/Jul/21 09:08
    Worklog Time Spent: 10m 
      Work Description: InigoSJ commented on a change in pull request #15126:
URL: https://github.com/apache/beam/pull/15126#discussion_r677264567



##########
File path: sdks/python/apache_beam/io/textio.py
##########
@@ -484,6 +485,9 @@ def __init__(
         from each source file. Must be 0 or higher. Large number of skipped
         lines might impact performance.
       coder: Coder used to decode each line.
+      with_context: If True, returns a Key Value with the key being the file

Review comment:
       I added a clarification on the doc, not sure if it's good enough




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 628283)
    Time Spent: 40m  (was: 0.5h)

> Add option to return filename from ReadAll transforms
> -----------------------------------------------------
>
>                 Key: BEAM-12665
>                 URL: https://issues.apache.org/jira/browse/BEAM-12665
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-py-common
>            Reporter: Inigo San Jose Visiers
>            Priority: P2
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> When using ReadAll transforms (as `ReadAllFromText` and similar), it would be 
> great to add the option to also return the filename.
> This would help with an use case of reading multiple files that are not known 
> at launch time and perform aggregations by file



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to