[
https://issues.apache.org/jira/browse/BEAM-12545?focusedWorklogId=632993&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-632993
]
ASF GitHub Bot logged work on BEAM-12545:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Aug/21 15:10
Start Date: 03/Aug/21 15:10
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #15265:
URL: https://github.com/apache/beam/pull/15265#issuecomment-891926284
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15265?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15265](https://codecov.io/gh/apache/beam/pull/15265?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(960a2be) into
[master](https://codecov.io/gh/apache/beam/commit/7b54b0bd3dac0fe59a11294217be969d0c03da86?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7b54b0b) will **decrease** coverage by `0.02%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/15265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15265 +/- ##
==========================================
- Coverage 83.86% 83.84% -0.03%
==========================================
Files 441 441
Lines 59724 59733 +9
==========================================
- Hits 50086 50081 -5
- Misses 9638 9652 +14
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/fileio.py](https://codecov.io/gh/apache/beam/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZmlsZWlvLnB5)
| `96.01% <100.00%> (+0.11%)` | :arrow_up: |
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `92.68% <0.00%> (-2.44%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==)
| `94.02% <0.00%> (-2.24%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `90.60% <0.00%> (-1.82%)` | :arrow_down: |
|
[sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=)
| `88.47% <0.00%> (-1.39%)` | :arrow_down: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/15265/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `90.42% <0.00%> (-1.07%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15265?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15265?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[7b54b0b...960a2be](https://codecov.io/gh/apache/beam/pull/15265?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 632993)
Time Spent: 40m (was: 0.5h)
> WriteToFile should support mime/encoding.
> -----------------------------------------
>
> Key: BEAM-12545
> URL: https://issues.apache.org/jira/browse/BEAM-12545
> Project: Beam
> Issue Type: Improvement
> Components: io-py-files
> Affects Versions: 2.30.0
> Reporter: Andreas Bergmeier
> Assignee: Pablo Estrada
> Priority: P3
> Labels: stale-assigned
> Time Spent: 40m
> Remaining Estimate: 0h
>
> For our use case, we need to write blobs to GCS. Also, we want to have both
> *{{Content-Type}}* and *{{Content-Encoding}}* set for these blobs.
> Since *{{WriteToFiles}}* currently only calls *{{Filesystem.create}}*
> without *{{mime_type}}* and *{{compression_type}}*, the resulting blobs are
> of type octet-stream.
> We imagine this to look something like:
> {code:python}
> metadata = sink.metadata()
> full_file_name, writer = _create_writer(base_path=self.base_path.get(),
> writer_key=(destination, w),
> mime_type=metadata.mime_type,
> compression_type=metadata.compression_type)
> {code}
> WDYT?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
