[
https://issues.apache.org/jira/browse/BEAM-12403?focusedWorklogId=634886&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-634886
]
ASF GitHub Bot logged work on BEAM-12403:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 00:09
Start Date: 06/Aug/21 00:09
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on a change in pull request
#15280:
URL: https://github.com/apache/beam/pull/15280#discussion_r683860783
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ParDoBoundMultiTranslator.java
##########
@@ -112,8 +113,10 @@ public void translate(
.collect(
Collectors.toMap(e -> e.getKey(), e -> ((PCollection<?>)
e.getValue()).getCoder()));
- boolean isStateful = DoFnSignatures.isStateful(transform.getFn());
- final Coder<?> keyCoder = isStateful ? ((KvCoder<?, ?>)
input.getCoder()).getKeyCoder() : null;
+ final Coder<?> keyCoder =
+ StateUtils.isStateful(transform.getFn())
Review comment:
I guess we might as well add a getKeyCoder() in the stateUtils to avoid
these logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 634886)
Time Spent: 2h 40m (was: 2.5h)
> Support user states in Samza portable runner
> --------------------------------------------
>
> Key: BEAM-12403
> URL: https://issues.apache.org/jira/browse/BEAM-12403
> Project: Beam
> Issue Type: Improvement
> Components: runner-samza
> Reporter: Xinyu Liu
> Assignee: Ke Wu
> Priority: P2
> Labels: portability-samza
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Add support of stateful ParDo in Samza portable runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
