[
https://issues.apache.org/jira/browse/BEAM-12690?focusedWorklogId=635219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-635219
]
ASF GitHub Bot logged work on BEAM-12690:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Aug/21 14:45
Start Date: 06/Aug/21 14:45
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#15249:
URL: https://github.com/apache/beam/pull/15249#discussion_r683803943
##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java
##########
@@ -100,9 +100,9 @@
Timer withOutputTimestamp(Instant outputTime);
/**
- * Returns the current relative time used by {@link #setRelative()} and
{@link #offset}. This can
- * be used by a client that self-manages relative timers (e.g. one that
stores the current timer
- * time in a state variable.
+ * * Returns the current relative time used by {@link #setRelative()} and
{@link #offset}. This
+ * can be used by a client that self-manages relative timers (e.g. one that
stores the current
Review comment:
Seems like an unintended formatting change ?
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -398,11 +424,31 @@ public void processElement(
storedBatchSizeBytes.readLater();
}
- long num = storedBatchSize.read();
- if (maxBufferingDuration.isLongerThan(Duration.ZERO) && num == 1) {
- // This is the first element in batch. Start counting buffering time
if a limit was set.
- bufferingTimer.offset(maxBufferingDuration).setRelative();
+ long num;
+ if (maxBufferingDuration.isLongerThan(Duration.ZERO)) {
+ minBufferedTs.readLater();
+ num = storedBatchSize.read();
+
+ long oldOutputTs =
+ MoreObjects.firstNonNull(
+ minBufferedTs.read(),
BoundedWindow.TIMESTAMP_MAX_VALUE.getMillis());
+ minBufferedTs.add(elementTs.getMillis());
+ // If this is the first element in the batch or if the timer's output
timestamp needs
+ // modifying, then set a
+ // timer.
+ if (num == 1 || minBufferedTs.read() != oldOutputTs) {
+ long targetTs =
+ MoreObjects.firstNonNull(
+ timerTs.read(),
+ bufferingTimer.getCurrentRelativeTime().getMillis()
Review comment:
I might be misunderstanding something but why can't we just set this to
"current time" + "maxBufferingDuration" ?
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
##########
@@ -340,6 +342,16 @@ public long getElementByteSize() {
@StateId(NUM_BYTES_IN_BATCH_ID)
private final StateSpec<CombiningState<Long, long[], Long>>
batchSizeBytesSpec;
+ private static final String TIMER_TIMESTAMP = "timerTs";
+
+ @StateId(TIMER_TIMESTAMP)
+ private final StateSpec<ValueState<Long>> timerTsSpec;
Review comment:
Probably we should add comments clarifying what each of these state Ids
are for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 635219)
Time Spent: 1h 20m (was: 1h 10m)
> GroupIntoBatches does not properly maintain watermarks
> ------------------------------------------------------
>
> Key: BEAM-12690
> URL: https://issues.apache.org/jira/browse/BEAM-12690
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: P2
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Since GIB buffers elements, the watermark should be held up to the minimum
> event-time buffered. Timer.withOutputTimestamp is the correct way to do this
> in Beam.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
