[
https://issues.apache.org/jira/browse/BEAM-12567?focusedWorklogId=636612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-636612
]
ASF GitHub Bot logged work on BEAM-12567:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/21 20:35
Start Date: 10/Aug/21 20:35
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #15303:
URL: https://github.com/apache/beam/pull/15303#issuecomment-896117065
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15303?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15303](https://codecov.io/gh/apache/beam/pull/15303?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(e049b59) into
[master](https://codecov.io/gh/apache/beam/commit/b5820a2261232042b9cbf5b99296071cdeeab77a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(b5820a2) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/beam/pull/15303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15303 +/- ##
==========================================
- Coverage 83.80% 83.80% -0.01%
==========================================
Files 441 441
Lines 59745 59745
==========================================
- Hits 50072 50069 -3
- Misses 9673 9676 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...apache\_beam/runners/dataflow/internal/apiclient.py](https://codecov.io/gh/apache/beam/pull/15303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9hcGljbGllbnQucHk=)
| `74.66% <100.00%> (ø)` | |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/15303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `90.42% <0.00%> (-1.07%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/15303/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `93.26% <0.00%> (-0.25%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15303?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15303?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[ce406c6...e049b59](https://codecov.io/gh/apache/beam/pull/15303?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 636612)
Time Spent: 1h 10m (was: 1h)
> Beam should retry failing GCS uploads
> --------------------------------------
>
> Key: BEAM-12567
> URL: https://issues.apache.org/jira/browse/BEAM-12567
> Project: Beam
> Issue Type: New Feature
> Components: io-py-gcp
> Reporter: Valentyn Tymofieiev
> Assignee: Ryan Thompson
> Priority: P2
> Labels: starter
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Sometimes GCS upload initiated by Beam stager fail due to a retriable error
> (such as 503), however Beam code and the underlying apitools-based storage
> client do not retry.
> We should retry some reasonable amount of times with a backoff logic, either
> on all or (better) on retriable errors.
> Code pointers:
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/internal/apiclient.py#L553-L554
> and similar:
> https://github.com/apache/beam/blob/c026c9fa00239a6f3650a6fa69f3aa864f692afe/sdks/python/apache_beam/io/gcp/gcsio.py#L635-L639
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
