[
https://issues.apache.org/jira/browse/BEAM-6165?focusedWorklogId=209821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-209821
]
ASF GitHub Bot logged work on BEAM-6165:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Mar/19 22:50
Start Date: 07/Mar/19 22:50
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7971:
[BEAM-6165] Flink portable metrics: get ptransform from MonitoringInfo, not
stage name
URL: https://github.com/apache/beam/pull/7971#discussion_r263590057
##########
File path:
runners/flink/src/test/java/org/apache/beam/runners/flink/FlinkSavepointTest.java
##########
@@ -133,6 +133,8 @@ public void testSavepointRestoreLegacy() throws Exception {
runSavepointAndRestore(false);
}
+ // TODO(ryan): make these fail when an exception is thrown (in the runner, I
+ // think?), instead of just timing out
Review comment:
It's not directly related, but when working on metrics PVR tests, if
something throws in the runner harness (I think), that manifests as a hang and
timeout of this test case, without a good stack trace.
Not essential to add this, ofc, but it's not the first time I've experienced
it while doing unrelated Flink work, so thought I'd try to raise awareness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 209821)
Time Spent: 7h 50m (was: 7h 40m)
> Send metrics to Flink in portable Flink runner
> ----------------------------------------------
>
> Key: BEAM-6165
> URL: https://issues.apache.org/jira/browse/BEAM-6165
> Project: Beam
> Issue Type: Improvement
> Components: runner-flink
> Affects Versions: 2.8.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Major
> Labels: metrics, portability, portability-flink
> Fix For: 2.10.0
>
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> Metrics are sent from the fn harness to runner in the Python SDK (and likely
> Java soon), but the portable Flink runner doesn't pass them on to Flink,
> which it should, so that users can see them in e.g. the Flink UI or via any
> Flink metrics reporters.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
