[
https://issues.apache.org/jira/browse/BEAM-12742?focusedWorklogId=637488&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637488
]
ASF GitHub Bot logged work on BEAM-12742:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/21 18:29
Start Date: 12/Aug/21 18:29
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #15322:
URL: https://github.com/apache/beam/pull/15322#discussion_r687986145
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/io/WriteFilesTest.java
##########
@@ -329,7 +329,11 @@ public void testWithRunnerDeterminedShardingUnbounded()
throws IOException {
}
@Test
- @Category({NeedsRunner.class, UsesUnboundedPCollections.class,
UsesTestStream.class})
+ @Category({
+ NeedsRunner.class,
+ UsesUnboundedPCollections.class,
+ UsesTestStreamWithProcessingTime.class
Review comment:
maybe keep the `UsesTestStream.class` category as well?
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##########
@@ -4670,7 +4670,7 @@ public void onTimer(
}
@Test
- @Category(NeedsRunner.class)
+ @Category({NeedsRunner.class, UsesTimersInParDo.class,
UsesTestStream.class})
Review comment:
Thanks a lot for adding all of these categories. It will be helpful.
Maybe add `UsesTestStream.class` to all of those that also have
`UsesTestStreamWithProcessingTime.class`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 637488)
Time Spent: 1h 40m (was: 1.5h)
> Samza Runner does not properly delete modified timer
> ----------------------------------------------------
>
> Key: BEAM-12742
> URL: https://issues.apache.org/jira/browse/BEAM-12742
> Project: Beam
> Issue Type: Bug
> Components: runner-samza
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> SamzaTimerInternalsFactory:267
> {code:java}
> final TimerData lastTimerData =
> TimerData.of(
> timerData.getTimerId(),
> timerData.getNamespace(),
> new Instant(lastTimestamp),
> new Instant(lastTimestamp),
> timerData.getDomain());
> deleteTimer(lastTimerData, false);
> {code}
> does not properly delete old timer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
