[
https://issues.apache.org/jira/browse/BEAM-12754?focusedWorklogId=637881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-637881
]
ASF GitHub Bot logged work on BEAM-12754:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/21 20:11
Start Date: 13/Aug/21 20:11
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #15327:
URL: https://github.com/apache/beam/pull/15327#issuecomment-898696042
Yeah - there's an effort right now to fix them.
On Fri, Aug 13, 2021 at 8:00 AM Steven Niemitz ***@***.***>
wrote:
> I guess these dataflow example jobs are broken on master too?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/15327#issuecomment-898517459>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AFAYJVJIOU2BVNAXW6QTRXLT4UXQHANCNFSM5CCB5PBQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
>
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
>
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 637881)
Time Spent: 2h 10m (was: 2h)
> RowCoderGenerator calls getValue multiple times
> -----------------------------------------------
>
> Key: BEAM-12754
> URL: https://issues.apache.org/jira/browse/BEAM-12754
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Affects Versions: 2.31.0
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: P2
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> RowCoderGenerator.encodeDelegate calls getValue for each field on a row
> twice, one to check if it is null in scanNullFields, and one to actually get
> the value to be encoded.
> If getValue is expensive (for example, it has to recursively adapt a type to
> a beam Row), this causes unneeded extra work.
> Instead we could call value.getValues to get all values once, then pass them
> to scanNullFields and re-use them when encoding the values.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
