[ 
https://issues.apache.org/jira/browse/BEAM-12735?focusedWorklogId=638268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-638268
 ]

ASF GitHub Bot logged work on BEAM-12735:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Aug/21 16:26
            Start Date: 16/Aug/21 16:26
    Worklog Time Spent: 10m 
      Work Description: ihji commented on a change in pull request #15307:
URL: https://github.com/apache/beam/pull/15307#discussion_r689682848



##########
File path: release/src/main/scripts/run_rc_validation.sh
##########
@@ -168,8 +184,7 @@ bq version
 echo "-----------------Checking gnome-terminal-----------------"
 if [[ -z `which gnome-terminal` ]]; then
   echo "You don't have gnome-terminal installed."
-  if [[ "$INSTALL_GNOME_TERMINAL" != true ]]; then
-    sudo apt-get upgrade
+  if [[ "$INSTALL_GNOME_TERMINAL" = true ]]; then

Review comment:
       I believe so. The software needs to be installed when the variable is 
true.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 638268)
    Time Spent: 1h 20m  (was: 1h 10m)

> Adding Python XLang examples to the RC validation script
> --------------------------------------------------------
>
>                 Key: BEAM-12735
>                 URL: https://issues.apache.org/jira/browse/BEAM-12735
>             Project: Beam
>          Issue Type: Improvement
>          Components: cross-language, release
>            Reporter: Heejong Lee
>            Assignee: Heejong Lee
>            Priority: P2
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Adding XLang Kafka Taxi example to the RC validation script



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to