[ 
https://issues.apache.org/jira/browse/BEAM-12694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400500#comment-17400500
 ] 

David Anderson commented on BEAM-12694:
---------------------------------------

In looking at the issue, the DICOM Store ID is being generated using a random 
string generator and the HTTP 409 error that is generated should be a very rare 
occurrence, but this won't impact the actual IO Connector and is really related 
to the Integration Test.

The issue is that the store id that was generated for the test already existed 
in that project, region, dataset combination. Should be improbable for 
happening regularly, hence I think the tag Flaky is appropriate. I believe this 
can be fixed by appending a timestamp after the randomly generated string to 
eliminate the possibility of a duplicate generated store id.

I will begin working on a fix today(08/17/2021)

> DICOMIoIntegrationTest flaky due to store ID (Python PreCommit)
> ---------------------------------------------------------------
>
>                 Key: BEAM-12694
>                 URL: https://issues.apache.org/jira/browse/BEAM-12694
>             Project: Beam
>          Issue Type: Bug
>          Components: test-failures
>    Affects Versions: 2.33.0
>            Reporter: Emily Ye
>            Assignee: Emily Ye
>            Priority: P0
>              Labels: currently-failing, flaky
>             Fix For: 2.33.0
>
>
> DICOMIoIntegrationTest flaky with error message: 
> requests.exceptions.HTTPError: 409 Client Error: Conflict for url:
> [https://healthcare.googleapis.com/v1/projects/apache-beam-testing/locations/us-central1/datasets/apache-beam-integration-testing/dicomStores?dicomStoreId=DICOM_store_Sb5HCWRmhFzqnPc]
>  * Example: https://ci-beam.apache.org/job/beam_PostCommit_Python36/4172/
> Looks like random string generator for name 
> ([https://github.com/apache/beam/blob/master/sdks/python/apache_beam/io/gcp/dicomio_integration_test.py#L129-L130)]
>  needs to be changed?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to