[
https://issues.apache.org/jira/browse/BEAM-11981?focusedWorklogId=638932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-638932
]
ASF GitHub Bot logged work on BEAM-11981:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/21 00:28
Start Date: 18/Aug/21 00:28
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #15342:
URL: https://github.com/apache/beam/pull/15342#issuecomment-900720694
> @ajamato Hi, I started to work also in this metric but I have a question,
I’m not sure what an acceptable error case metric would be in the
[read](https://github.com/apache/beam/blob/68457fbaf9000c6b75972ebb588cc05116e0195d/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L160)
method, would it be needed to add a try catch to check for exceptions in
[advance()](https://github.com/apache/beam/blob/68457fbaf9000c6b75972ebb588cc05116e0195d/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L166)
and log and re-throw?
> Thanks
Yes the goal here is to get the error code and report that as a status to
the metric. Or 'ok' on success.
Do you need to catch an exception? Most likely. Though some client libraries
have some other mechanism to get the error (like a status on the response).
Please research the library and identify the correct way to capture the
error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 638932)
Time Spent: 2.5h (was: 2h 20m)
> Java Bigtable - Implement IO Request Count metrics
> --------------------------------------------------
>
> Key: BEAM-11981
> URL: https://issues.apache.org/jira/browse/BEAM-11981
> Project: Beam
> Issue Type: Test
> Components: io-java-gcp
> Reporter: Alex Amato
> Priority: P3
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's
> needed to instrument this IO with Request Count metrics is found in this
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
