[
https://issues.apache.org/jira/browse/BEAM-12767?focusedWorklogId=639983&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-639983
]
ASF GitHub Bot logged work on BEAM-12767:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/21 18:28
Start Date: 19/Aug/21 18:28
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #15338:
URL: https://github.com/apache/beam/pull/15338#issuecomment-900552905
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15338](https://codecov.io/gh/apache/beam/pull/15338?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2ab0024) into
[master](https://codecov.io/gh/apache/beam/commit/af59192ac95a564ca3d29b6385a6d1448f5a407d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(af59192) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 2ab0024 differs from pull request most recent
head 7afc8c6. Consider uploading reports for the commit 7afc8c6 to get more
accurate results
[](https://codecov.io/gh/apache/beam/pull/15338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15338 +/- ##
==========================================
- Coverage 83.81% 83.81% -0.01%
==========================================
Files 441 441
Lines 59773 59773
==========================================
- Hits 50101 50096 -5
- Misses 9672 9677 +5
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/15338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5)
| `91.47% <0.00%> (-0.78%)` | :arrow_down: |
|
[...nners/portability/fn\_api\_runner/worker\_handlers.py](https://codecov.io/gh/apache/beam/pull/15338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL3dvcmtlcl9oYW5kbGVycy5weQ==)
| `79.44% <0.00%> (-0.35%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `88.85% <0.00%> (-0.16%)` | :arrow_down: |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/15338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `88.73% <0.00%> (-0.15%)` | :arrow_down: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/15338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `93.51% <0.00%> (-0.13%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/util.py](https://codecov.io/gh/apache/beam/pull/15338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy91dGlsLnB5)
| `95.98% <0.00%> (+0.16%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15338?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15338?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[80da0ec...7afc8c6](https://codecov.io/gh/apache/beam/pull/15338?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 639983)
Time Spent: 5h 10m (was: 5h)
> Improve UX of PipelineOptions parsing
> -------------------------------------
>
> Key: BEAM-12767
> URL: https://issues.apache.org/jira/browse/BEAM-12767
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Steve Niemitz
> Assignee: Steve Niemitz
> Priority: P2
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Attempting to parse complex types in PipelineOptions can have a suboptimal
> UX. For example, if the option type being parsed is an Instant, simply
> passing in:
> {{--myInstant=2021-07-17 }}{{will fail. Instead the user must pass in
> --myInstant="2021-07-17"}}{{, however, this is complicated by the fact that
> the quotes will be stripped from the arguments in many cases, requiring a
> user to actually pass in --myInstant='"2021-07-17"'. }}
> This can be improved by attempting to parse the input twice, once as-is, and
> then trying again by automatically wrapping it in quotes.
> Additionally, it's impossible to use a custom JsonDeserializer on a pipeline
> option property. We should allow using @JsonDeserialize on the getters to
> supply a custom one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
