[
https://issues.apache.org/jira/browse/BEAM-12100?focusedWorklogId=640060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640060
]
ASF GitHub Bot logged work on BEAM-12100:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/21 23:54
Start Date: 19/Aug/21 23:54
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #15174:
URL: https://github.com/apache/beam/pull/15174#issuecomment-902327635
> Yes, I tried but it causes a compilation error because of the return type
of `.asSingletonView()`. I tried setting ` .withoutDefaults()` just for
Unbounded PCollections, and it is working now.
[7473306](https://github.com/apache/beam/commit/7473306d414322f284fb3b29f16e280108f9e2d5)
I think what we really want is to check whether or not the PCollection is in
the global window, which is orthogonal to whether or not it's bounded. (In the
test data, the bounded input is globally windowed while the unbounded input is
not, but that's not always true generally.)
I'll try to do a full review of this PR tomorrow, but I might not get to it
till next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 640060)
Time Spent: 4h (was: 3h 50m)
> SUM should error when overflow/underflow occurs.
> ------------------------------------------------
>
> Key: BEAM-12100
> URL: https://issues.apache.org/jira/browse/BEAM-12100
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 4h
> Remaining Estimate: 0h
>
> SELECT SUM(col1) FROM (SELECT CAST(9223372036854775807 as int64) as col1
> UNION ALL SELECT CAST(1 as int64))
> should return an error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
