[
https://issues.apache.org/jira/browse/BEAM-12751?focusedWorklogId=640563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-640563
]
ASF GitHub Bot logged work on BEAM-12751:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Aug/21 00:16
Start Date: 23/Aug/21 00:16
Worklog Time Spent: 10m
Work Description: baeminbo commented on pull request #15335:
URL: https://github.com/apache/beam/pull/15335#issuecomment-903355764
@pabloem I fixed the issue of not-failing for already-existing job above.
For this, I added a logic to check the `clientRequestId` of the job returned
from the API and throw an `DataflowJobAlreadyExistsError` if not matched. And,
I added two unit tests to `apiclient_test.py`. Could you review this again?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 640563)
Time Spent: 4h (was: 3h 50m)
> Python DataflowRunner doesn't set client_request_id
> ---------------------------------------------------
>
> Key: BEAM-12751
> URL: https://issues.apache.org/jira/browse/BEAM-12751
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Environment: python
> Reporter: Minbo Bae
> Priority: P2
> Time Spent: 4h
> Remaining Estimate: 0h
>
> Currently, [Java DataflowRunner|#L1026] sets {{clientRequestId}}, but
> [Python
> DataflowRunner|https://github.com/apache/beam/blob/v2.31.0/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py]
> has no such logic.
> This causes an issue with job creation when the first try is failed with
> DEADLINE_EXCEEDED (but actually job successfully created), because the second
> try will fail with "There is already an active job named...". As per
> [Dataflow public
> doc|https://cloud.google.com/dataflow/docs/reference/rest/v1b3/projects.locations.jobs],
> `clientRequestId` must be set to avoid this issue.
> In addition, as the retry happens in
> [google-apitools|https://github.com/google/apitools/blob/v0.5.31/apitools/base/py/http_wrapper.py#L346-L360]
> and it doesn't print any logs, the error message is difficult to understand
> and there is actually a successfully created job even if it returns the error.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
