[
https://issues.apache.org/jira/browse/BEAM-11987?focusedWorklogId=641294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641294
]
ASF GitHub Bot logged work on BEAM-11987:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/21 20:08
Start Date: 24/Aug/21 20:08
Worklog Time Spent: 10m
Work Description: ajamato commented on a change in pull request #15328:
URL: https://github.com/apache/beam/pull/15328#discussion_r695166011
##########
File path: sdks/python/apache_beam/io/gcp/datastore/v1new/datastoreio.py
##########
@@ -26,20 +26,27 @@
import logging
import time
+from google.api_core.exceptions import ClientError
Review comment:
Nothing is needed in the except block. This is needed due to the way
this dep is loaded, its not always available when the module is loaded in some
cases (I am not sure why in detail though, some other devs know the details on
this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 641294)
Time Spent: 3h 20m (was: 3h 10m)
> Python Datastore - Implement IO Request Count metric
> ----------------------------------------------------
>
> Key: BEAM-11987
> URL: https://issues.apache.org/jira/browse/BEAM-11987
> Project: Beam
> Issue Type: Test
> Components: io-py-gcp
> Reporter: Alex Amato
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's
> needed to instrument this IO with Request Count metrics is found in this
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
