[
https://issues.apache.org/jira/browse/BEAM-12781?focusedWorklogId=641381&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641381
]
ASF GitHub Bot logged work on BEAM-12781:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/21 23:28
Start Date: 24/Aug/21 23:28
Worklog Time Spent: 10m
Work Description: robertwb commented on a change in pull request #15357:
URL: https://github.com/apache/beam/pull/15357#discussion_r695283184
##########
File path: sdks/python/apache_beam/coders/coders.py
##########
@@ -18,6 +18,20 @@
"""Collection of useful coders.
Only those coders listed in __all__ are part of the public API of this module.
+
+## On usage of `pickle`, `dill` and `pickler` in Beam
+
+In Beam, we generally we use `pickle` for pipeline elements and `dill` for
+more complex types, like user functions.
+
+`pickler` is Beam's own wrapping of dill + compression + error handling.
+It serves also as an API to mask the actual encoding layer (so we can
+change it from `dill` if necessary).
+
+We created `_MemoizingPickleCoder` to improve performance when serializing
+complex user types for the execution of SDF. Specifically to address
+BEAM-12781, where `BoundedSource` instances are being encoded.
Review comment:
where many identical `BoundedSource` instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 641381)
Time Spent: 3h (was: 2h 50m)
> SDFBoundedSourceReader behaves much slower compared with the original
> behavior of BoundedSource
> -----------------------------------------------------------------------------------------------
>
> Key: BEAM-12781
> URL: https://issues.apache.org/jira/browse/BEAM-12781
> Project: Beam
> Issue Type: Bug
> Components: io-py-common
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: P1
> Fix For: 2.33.0
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
