[
https://issues.apache.org/jira/browse/BEAM-12796?focusedWorklogId=641833&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-641833
]
ASF GitHub Bot logged work on BEAM-12796:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Aug/21 17:11
Start Date: 25/Aug/21 17:11
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #15388:
URL: https://github.com/apache/beam/pull/15388#issuecomment-905092144
#
[Codecov](https://codecov.io/gh/apache/beam/pull/15388?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#15388](https://codecov.io/gh/apache/beam/pull/15388?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(4fa1f49) into
[master](https://codecov.io/gh/apache/beam/commit/7611831443399f31fc505bc3451f2b56f245d4e4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(7611831) will **increase** coverage by `0.00%`.
> The diff coverage is `88.23%`.
[](https://codecov.io/gh/apache/beam/pull/15388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15388 +/- ##
=======================================
Coverage 83.66% 83.67%
=======================================
Files 440 440
Lines 59950 59993 +43
=======================================
+ Hits 50158 50198 +40
- Misses 9792 9795 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/15388?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/io/gcp/bigquery.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vZ2NwL2JpZ3F1ZXJ5LnB5)
| `67.49% <60.00%> (-0.13%)` | :arrow_down: |
|
[sdks/python/apache\_beam/transforms/combiners.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9jb21iaW5lcnMucHk=)
| `93.71% <100.00%> (+0.11%)` | :arrow_up: |
|
[.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5)
| `96.72% <0.00%> (-1.64%)` | :arrow_down: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `90.42% <0.00%> (-1.07%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `88.80% <0.00%> (-0.16%)` | :arrow_down: |
|
[...ks/python/apache\_beam/coders/coders\_test\_common.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyc190ZXN0X2NvbW1vbi5weQ==)
| `98.51% <0.00%> (+0.01%)` | :arrow_up: |
|
[sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5)
| `86.21% <0.00%> (+0.06%)` | :arrow_up: |
|
[...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==)
| `93.64% <0.00%> (+0.12%)` | :arrow_up: |
|
[sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==)
| `87.98% <0.00%> (+0.18%)` | :arrow_up: |
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15388/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `95.12% <0.00%> (+7.31%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/15388?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/15388?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[76d0dcb...4fa1f49](https://codecov.io/gh/apache/beam/pull/15388?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 641833)
Time Spent: 4h 10m (was: 4h)
> Executing a BQ pipeline without the new BQ read API library results in a
> TypeError
> ----------------------------------------------------------------------------------
>
> Key: BEAM-12796
> URL: https://issues.apache.org/jira/browse/BEAM-12796
> Project: Beam
> Issue Type: Bug
> Components: io-py-gcp
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Vachan Shetty
> Priority: P1
> Fix For: 2.33.0
>
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Executing a BQ pipeline without the new BQ read API library results in
> following error which is not helpful.
> {{if (isinstance(self.table_reference, TableReference) and
> self.table_reference.projectId is None):
> E TypeError: isinstance() arg 2 must be a type or tuple of types}}
> {{}}
> This seems to be due to the new import here:
> https://github.com/apache/beam/blob/76d0dcb6081b8a8f03e4292a4f99274a8c9a5965/sdks/python/apache_beam/io/gcp/bigquery.py#L335
> {{added by [https://github.com/apache/beam/pull/15185]}}
> {{}}
> {{Previously BQ client library was a part of Beam so this is a new failure
> mode. We should provide a better error message here.}}
> {{}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
