[
https://issues.apache.org/jira/browse/BEAM-6796?focusedWorklogId=210686&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210686
]
ASF GitHub Bot logged work on BEAM-6796:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/19 17:40
Start Date: 10/Mar/19 17:40
Worklog Time Spent: 10m
Work Description: mxm commented on pull request #8023: [BEAM-6796][flink]
Fully finish bundle before timer callback
URL: https://github.com/apache/beam/pull/8023#discussion_r264048476
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java
##########
@@ -679,6 +685,12 @@ protected final void invokeFinishBundle() {
pushbackDoFnRunner.finishBundle();
elementCount = 0L;
lastFinishBundleTime =
getProcessingTimeService().getCurrentProcessingTime();
+ // callback only after current bundle was fully finalized
+ // it could start a new bundle, for example resulting from timer
processing
+ if (bundleFinishedCallback != null) {
+ bundleFinishedCallback.run();
+ bundleFinishedCallback = null;
Review comment:
Could you share more from your findings? It looks like the only difference
is that `elementCount/lastFinishBundleTime` is reset before calling
`bundleFinishedCallback`. I see that starting a new bundle can cause problems
because it may be finalized immediately due to the element count not being
reset yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 210686)
Time Spent: 20m (was: 10m)
> Portable Flink runner error in finish bundle timer processing
> -------------------------------------------------------------
>
> Key: BEAM-6796
> URL: https://issues.apache.org/jira/browse/BEAM-6796
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.11.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The timer callback fails since the bundle was already finished and a no new
> bundle started.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
