[
https://issues.apache.org/jira/browse/BEAM-6722?focusedWorklogId=210895&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210895
]
ASF GitHub Bot logged work on BEAM-6722:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/19 09:10
Start Date: 11/Mar/19 09:10
Worklog Time Spent: 10m
Work Description: echauchot commented on pull request #8000: [BEAM-6722]
Raise embedded Cassandra startup timeout to avoid flakiness in Cassandra tests
URL: https://github.com/apache/beam/pull/8000#discussion_r264139588
##########
File path:
sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOTest.java
##########
@@ -126,9 +126,15 @@ public static void startCassandra() throws Exception {
@AfterClass
public static void stopCassandra() {
- EmbeddedCassandraServerHelper.cleanEmbeddedCassandra();
- session.close();
- cluster.close();
+ if (cluster != null && session != null) {
+ EmbeddedCassandraServerHelper.cleanEmbeddedCassandra();
+ session.close();
+ cluster.close();
+ } else {
+ if (cluster != null){
Review comment:
No, it is not the same validation. the `if (cluster != null)` is under an
`else`. So it is the code for the case `session == null && cluster != null`
i.e. the cluster is created but not the session. This is the case @mxn reported.
Your suggestion is not correct either, because both cluster and session need
to be not null to clean cassandra, and we cannot close cluster and session
beforewards because they are needed for the cleaning process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 210895)
Time Spent: 6h 10m (was: 6h)
> :beam-sdks-java-io-cassandra:test is flaky
> ------------------------------------------
>
> Key: BEAM-6722
> URL: https://issues.apache.org/jira/browse/BEAM-6722
> Project: Beam
> Issue Type: Test
> Components: io-java-cassandra
> Reporter: Maximilian Michels
> Assignee: Etienne Chauchot
> Priority: Major
> Labels: flake, flaky-test, triaged
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> I think this could be caused by the same issue as BEAM-6268.
> {noformat}
> 20:19:23 FAILURE: Build failed with an exception.
> 20:19:23
> 20:19:23 * What went wrong:
> 20:19:23 Execution failed for task ':beam-sdks-java-io-cassandra:test'.
> 20:19:23 > There were failing tests. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit@2/src/sdks/java/io/cassandra/build/reports/tests/test/index.html
> 20:19:23
> {noformat}
> https://builds.apache.org/job/beam_PreCommit_Java_Commit/4414/console
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
