[ 
https://issues.apache.org/jira/browse/BEAM-12383?focusedWorklogId=644211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-644211
 ]

ASF GitHub Bot logged work on BEAM-12383:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/21 14:59
            Start Date: 31/Aug/21 14:59
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on a change in pull request #15094:
URL: https://github.com/apache/beam/pull/15094#discussion_r698848265



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -332,6 +332,12 @@ class BeamModulePlugin implements Plugin<Project> {
       "--environment_cache_millis=10000",

Review comment:
       I assume the Go SDK doesn't have this flag to pass through the pipeline 
options yet. We may want to consider it in the future.

##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -262,22 +262,19 @@ elif [[ "$RUNNER" == "flink" || "$RUNNER" == "spark" || 
"$RUNNER" == "samza" ||
           --job-port $JOB_PORT \
           --expansion-port 0 \
           --artifact-port 0 &
-      SIMULTANEOUS=1

Review comment:
       I think you need to rebase your PR? Didn't you already merge this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 644211)
    Time Spent: 24h 10m  (was: 24h)

> Go SDK test added to Kafka XLang test suite
> -------------------------------------------
>
>                 Key: BEAM-12383
>                 URL: https://issues.apache.org/jira/browse/BEAM-12383
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: P2
>          Time Spent: 24h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to