[
https://issues.apache.org/jira/browse/BEAM-12823?focusedWorklogId=646034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646034
]
ASF GitHub Bot logged work on BEAM-12823:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Sep/21 20:37
Start Date: 02/Sep/21 20:37
Worklog Time Spent: 10m
Work Description: xinyuiscool commented on a change in pull request
#15421:
URL: https://github.com/apache/beam/pull/15421#discussion_r701405816
##########
File path:
runners/samza/src/main/java/org/apache/beam/runners/samza/translation/SamzaTestStreamTranslator.java
##########
@@ -90,11 +97,54 @@ public void translate(
ctx.registerInputMessageStream(output, inputDescriptor);
}
+ @SuppressWarnings("unchecked")
@Override
public void translatePortable(
PipelineNode.PTransformNode transform,
QueryablePipeline pipeline,
PortableTranslationContext ctx) {
- throw new SamzaException("TestStream is not supported in portable by Samza
runner");
+ final ByteString bytes = transform.getTransform().getSpec().getPayload();
+ final Coder<T> coder;
Review comment:
Shall we wrap line 107 - 129 into a private static method, e.g.
createTestStreamDecoder()? The good thing about static is that your lambda
function instance won't hold on to the outer class instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646034)
Time Spent: 6h (was: 5h 50m)
> TestStream Support in Samza Portable Runner
> -------------------------------------------
>
> Key: BEAM-12823
> URL: https://issues.apache.org/jira/browse/BEAM-12823
> Project: Beam
> Issue Type: New Feature
> Components: runner-samza
> Reporter: Ke Wu
> Assignee: Ke Wu
> Priority: P2
> Labels: portability-samza
> Time Spent: 6h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
