[
https://issues.apache.org/jira/browse/BEAM-12153?focusedWorklogId=646199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646199
]
ASF GitHub Bot logged work on BEAM-12153:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/21 07:34
Start Date: 03/Sep/21 07:34
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #15267:
URL: https://github.com/apache/beam/pull/15267#discussion_r701662111
##########
File path:
runners/core-java/src/main/java/org/apache/beam/runners/core/helpers/package-info.java
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/** Provides helpers for Beam runner authors. */
+@DefaultAnnotation(NonNull.class)
+package org.apache.beam.runners.core.helpers;
Review comment:
agree, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646199)
Time Spent: 6h 50m (was: 6h 40m)
> OOM on GBK in SparkRunner and SpartStructuredStreamingRunner
> ------------------------------------------------------------
>
> Key: BEAM-12153
> URL: https://issues.apache.org/jira/browse/BEAM-12153
> Project: Beam
> Issue Type: Bug
> Components: runner-spark
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: P3
> Time Spent: 6h 50m
> Remaining Estimate: 0h
>
> We have being experiencing OOM errors on GroupByKey in batch mode in both
> Spark runners even if behind the woods spark spills data to disk in such
> cases: taking a look at the translation in the two runners, it might be due
> to using ReduceFnRunner for merging windows in GBK translation.
> ReduceFnRunner.processElements expects to have all elements to merge the
> windows between each other.:
> RDD spark runner:
> https://github.com/apache/beam/blob/752798e3b0e6911fa84f8d138dacccdb6fcc85ef/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkGroupAlsoByWindowViaOutputBufferFn.java#L99
> structured streaming spark: runner:
> [https://github.com/apache/beam/blob/752798e3b0e6911fa84f8d138dacccdb6fcc85ef/runners/spark/2/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/functions/GroupAlsoByWindowViaOutputBufferFn.java#L74|https://github.com/apache/beam/blob/752798e3b0e6911fa84f8d138dacccdb6fcc85ef/runners/spark/2/src/main/java/org/apache/beam/runners/spark/structuredstreaming/translation/batch/functions/GroupAlsoByWindowViaOutputBufferFn.java#L106]
> Even replacing the Iterable with an Iterator in ReduceFnRunner to avoid
> materialization does not work because deep in
> ReduceFnRunner.processElements(), the collection is iterated twice.
> It could be better to do what flink runner does and translate GBK as
> CombinePerKey with a Concatenate combine fn and thus avoid elements
> materialization.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
