[
https://issues.apache.org/jira/browse/BEAM-3385?focusedWorklogId=646422&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646422
]
ASF GitHub Bot logged work on BEAM-3385:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/21 17:58
Start Date: 03/Sep/21 17:58
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #15456:
URL: https://github.com/apache/beam/pull/15456#discussion_r702076735
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/coders/SerializableCoder.java
##########
@@ -39,6 +39,9 @@
/**
* A {@link Coder} for Java classes that implement {@link Serializable}.
*
+ * <p>{@link SerializableCoder} should be used only for objects that have
proper equals() and
+ * hashCode()
Review comment:
```suggestion
* <p>{@link SerializableCoder} should be used only for objects that have
proper {@link Object#equals} and
* {@link Object#hashCode} implementations.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646422)
Time Spent: 0.5h (was: 20m)
> SerializableCoder should document types need to implement equals and hashCode
> correctly
> ---------------------------------------------------------------------------------------
>
> Key: BEAM-3385
> URL: https://issues.apache.org/jira/browse/BEAM-3385
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Luke Cwik
> Priority: P3
> Labels: Clarified
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We should document that SerializableCoder should be used only for objects
> that have a proper equals() and hashCode(). Because we need some structural
> value for mutation detection, and since this coder is non-deterministic, it
> can't provide any structural value other than the object itself. In this
> case, I suppose, the work would involve just documentation.
> Source for this JIRA stems from this discussion on dev@:
> https://lists.apache.org/thread.html/8b2dcf09ba8e46b3c008293d99e4028d10463148b68326687dc29a4d@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
