[
https://issues.apache.org/jira/browse/BEAM-12838?focusedWorklogId=646543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646543
]
ASF GitHub Bot logged work on BEAM-12838:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/21 01:03
Start Date: 04/Sep/21 01:03
Worklog Time Spent: 10m
Work Description: ihji commented on a change in pull request #15454:
URL: https://github.com/apache/beam/pull/15454#discussion_r702212390
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -849,10 +851,16 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
}
}
- private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
+ private Pair<List<DataflowPackage>, RunnerApi.Pipeline> stageArtifacts(
+ RunnerApi.Pipeline pipeline) {
+ RunnerApi.Pipeline.Builder pipelineBuilder = pipeline.toBuilder();
+ RunnerApi.Components.Builder componentsBuilder =
pipelineBuilder.getComponentsBuilder();
+ componentsBuilder.clearEnvironments();
Review comment:
Had offline discussion so resolve the comment.
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -849,10 +851,16 @@ private Debuggee registerDebuggee(CloudDebugger
debuggerClient, String uniquifie
}
}
- private List<DataflowPackage> stageArtifacts(RunnerApi.Pipeline pipeline) {
+ private Pair<List<DataflowPackage>, RunnerApi.Pipeline> stageArtifacts(
+ RunnerApi.Pipeline pipeline) {
+ RunnerApi.Pipeline.Builder pipelineBuilder = pipeline.toBuilder();
+ RunnerApi.Components.Builder componentsBuilder =
pipelineBuilder.getComponentsBuilder();
+ componentsBuilder.clearEnvironments();
ImmutableList.Builder<StagedFile> filesToStageBuilder =
ImmutableList.builder();
for (Map.Entry<String, RunnerApi.Environment> entry :
pipeline.getComponents().getEnvironmentsMap().entrySet()) {
+ RunnerApi.Environment.Builder environmentBuilder =
entry.getValue().toBuilder();
+ environmentBuilder.clearDependencies();
Review comment:
Had offline discussion so resolve the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646543)
Time Spent: 1h 10m (was: 1h)
> Update artifact local path for DataflowRunner Java
> --------------------------------------------------
>
> Key: BEAM-12838
> URL: https://issues.apache.org/jira/browse/BEAM-12838
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Fix For: 2.33.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Update artifact local path for DataflowRunner Java
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
