[
https://issues.apache.org/jira/browse/BEAM-6719?focusedWorklogId=211190&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211190
]
ASF GitHub Bot logged work on BEAM-6719:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/19 17:55
Start Date: 11/Mar/19 17:55
Worklog Time Spent: 10m
Work Description: pabloem commented on issue #7813: [BEAM-6719] Allow
multiple Joins in the same pipeline
URL: https://github.com/apache/beam/pull/7813#issuecomment-471651186
Hello Daniel! I'm so sorry that we did not pick this up. Luke is away on
leave, so we'd need to get you a new reviewer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 211190)
Time Spent: 20m (was: 10m)
> Allow multiple Joins in the same pipeline
> -----------------------------------------
>
> Key: BEAM-6719
> URL: https://issues.apache.org/jira/browse/BEAM-6719
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-join-library
> Reporter: Daniel Mescheder
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently it is not possible to have multiple joins in the same pipeline
> without wrapping them in individual PTransforms as this would generate name
> clashes.
> Consider the following test case:
> {code:java}
> @Test
> public void testMultipleJoinsInSamePipeline() {
> leftListOfKv.add(KV.of("Key2", 4L));
> PCollection<KV<String, Long>> leftCollection = p.apply("CreateLeft",
> Create.of(leftListOfKv));
> rightListOfKv.add(KV.of("Key2", "bar"));
> PCollection<KV<String, String>> rightCollection = p.apply("CreateRight",
> Create.of(rightListOfKv));
> expectedResult.add(KV.of("Key2", KV.of(4L, "bar")));
> PCollection<KV<String, KV<Long, String>>> output1 =
> Join.innerJoin(leftCollection, rightCollection);
> PCollection<KV<String, KV<Long, String>>> output2 =
> Join.innerJoin(leftCollection, rightCollection);
> PAssert.that(output1).containsInAnyOrder(expectedResult);
> PAssert.that(output2).containsInAnyOrder(expectedResult);
> p.run();
> }
> {code}
> This fails because of clashing names in the pipeline and there is currently
> no way to use the join library to give the joins different names.
> Therefore I find myself routinely wrapping joins in new PTransforms which
> leads me to believe that this should be part of the library itself.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
