[
https://issues.apache.org/jira/browse/BEAM-12634?focusedWorklogId=649257&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-649257
]
ASF GitHub Bot logged work on BEAM-12634:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/21 15:12
Start Date: 10/Sep/21 15:12
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #15464:
URL: https://github.com/apache/beam/pull/15464#discussion_r706263263
##########
File path:
sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/AutoScaler.java
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.jms;
+
+import java.io.Serializable;
+import org.apache.beam.sdk.io.UnboundedSource;
+
+/**
+ * Enables users to specify their own `JMS` backlog reporters enabling {@link
JmsIO} to report
+ * {@link UnboundedSource.UnboundedReader#getTotalBacklogBytes()}.
+ */
+public interface AutoScaler extends Serializable {
+
+ /** The {@link AutoScaler} is started when the {@link
JmsIO.UnboundedJmsReader} is started. */
+ void start();
+
+ /**
+ * Returns the size of the backlog of unread data in the underlying data
source represented by all
+ * splits of this source.
+ *
+ * <p>It should be overridden in order to allow the runner to scale the
amount of resources
+ * allocated to the pipeline.
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 649257)
Time Spent: 1h 10m (was: 1h)
> JmsIO autoscaling ability
> -------------------------
>
> Key: BEAM-12634
> URL: https://issues.apache.org/jira/browse/BEAM-12634
> Project: Beam
> Issue Type: Improvement
> Components: io-java-jms
> Affects Versions: 2.31.0
> Reporter: Vincent BALLADA
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> JmsIO doesn't implement the getSplitBacklogBytes or getTotalBacklogBytes
> method, there is no backlog estimate.
> Dataflow runner autoscaler is not able to allocate workers depending on the
> backlog size (scale down and up).
> As a consequence autoscaling cannot be used, a fix number of workers must be
> configured.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
