[ 
https://issues.apache.org/jira/browse/BEAM-12383?focusedWorklogId=652449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652449
 ]

ASF GitHub Bot logged work on BEAM-12383:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Sep/21 19:52
            Start Date: 17/Sep/21 19:52
    Worklog Time Spent: 10m 
      Work Description: youngoli commented on a change in pull request #15094:
URL: https://github.com/apache/beam/pull/15094#discussion_r711314088



##########
File path: sdks/go/test/integration/io/xlang/kafka/jar.go
##########
@@ -13,13 +13,18 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// Exclude OSes which do not support the timeout command or syscall.SIGTERM.

Review comment:
       AFAIK there's no way to implement timeout programmatically. Its purpose 
is to shut down the container if the test binary doesn't get a chance to do so. 
Checking for the timeout command sounds good though, I'll see if there's an 
OS-independent way to do that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 652449)
    Time Spent: 26h  (was: 25h 50m)

> Go SDK test added to Kafka XLang test suite
> -------------------------------------------
>
>                 Key: BEAM-12383
>                 URL: https://issues.apache.org/jira/browse/BEAM-12383
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: P2
>          Time Spent: 26h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to