[
https://issues.apache.org/jira/browse/BEAM-12258?focusedWorklogId=653297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653297
]
ASF GitHub Bot logged work on BEAM-12258:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/21 00:11
Start Date: 21/Sep/21 00:11
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#14734:
URL: https://github.com/apache/beam/pull/14734#discussion_r712602589
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubTableProviderIT.java
##########
@@ -439,8 +440,20 @@ public void testSQLLimit() throws Exception {
return result.build();
});
- eventsTopic.assertSubscriptionEventuallyCreated(
- pipeline.getOptions().as(GcpOptions.class).getProject(),
Duration.standardMinutes(5));
+ try {
+ eventsTopic.assertSubscriptionEventuallyCreated(
+ pipeline.getOptions().as(GcpOptions.class).getProject(),
Duration.standardMinutes(5));
+ } catch (AssertionError assertionError) {
+ // If we timed out, check if the forked thread had an exception. If
something
+ // did go wrong there this call will raise an ExecutionException, which
we allow to bubble
+ // up.
+ try {
+ queryResult.get(1, TimeUnit.SECONDS);
Review comment:
The timeout is for the case where no exception was raised on the forked
thread, but we still didn't create a subscription for some reason. If we just
call `get()` then we would hang indefinitely in that case. I changed the
timeout to 0 seconds (which is maybe what you thought `get()` would do?), to
make the intention more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 653297)
Time Spent: 2.5h (was: 2h 20m)
> SQL postcommit timing out
> -------------------------
>
> Key: BEAM-12258
> URL: https://issues.apache.org/jira/browse/BEAM-12258
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql, test-failures
> Reporter: Kyle Weaver
> Assignee: Brian Hulette
> Priority: P1
> Fix For: 2.31.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> SQL postcommit ([https://ci-beam.apache.org/job/beam_PostCommit_SQL/)] is
> timing out (and the timeout is already 4 hours!). Looks like it's stuck on
> "Task :sdks:java:extensions:sql:integrationTest".
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
