[
https://issues.apache.org/jira/browse/BEAM-10708?focusedWorklogId=653700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653700
]
ASF GitHub Bot logged work on BEAM-10708:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/21 17:06
Start Date: 21/Sep/21 17:06
Worklog Time Spent: 10m
Work Description: andyxiexu commented on a change in pull request #15518:
URL: https://github.com/apache/beam/pull/15518#discussion_r713248395
##########
File path:
sdks/python/apache_beam/runners/interactive/display/pcoll_visualization.py
##########
@@ -238,7 +239,13 @@ def continuous_update_display(): # pylint:
disable=unused-variable
def visualize_computed_pcoll(
- pcoll_name: str, pcoll: beam.pvalue.PCollection) -> None:
+ pcoll_name: str,
+ pcoll: beam.pvalue.PCollection,
+ max_n: int,
+ max_duration_secs: float,
+ dynamic_plotting_interval: Optional[int] = None,
+ include_window_info: bool = False,
+ display_facets: bool = False) -> None:
Review comment:
Can you add some comments for these new parameters? I have to look at
the implementation to understand their meanings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 653700)
Time Spent: 40h 40m (was: 40.5h)
> InteractiveRunner cannot execute pipeline with cross-language transform
> -----------------------------------------------------------------------
>
> Key: BEAM-10708
> URL: https://issues.apache.org/jira/browse/BEAM-10708
> Project: Beam
> Issue Type: Bug
> Components: cross-language
> Reporter: Brian Hulette
> Assignee: Ning
> Priority: P2
> Time Spent: 40h 40m
> Remaining Estimate: 0h
>
> The InteractiveRunner crashes when given a pipeline that includes a
> cross-language transform.
> Here's the example I tried to run in a jupyter notebook:
> {code:python}
> p = beam.Pipeline(InteractiveRunner())
> pc = (p | SqlTransform("""SELECT
> CAST(1 AS INT) AS `id`,
> CAST('foo' AS VARCHAR) AS `str`,
> CAST(3.14 AS DOUBLE) AS `flt`"""))
> df = interactive_beam.collect(pc)
> {code}
> The problem occurs when
> [pipeline_fragment.py|https://github.com/apache/beam/blob/dce1eb83b8d5137c56ac58568820c24bd8fda526/sdks/python/apache_beam/runners/interactive/pipeline_fragment.py#L66]
> creates a copy of the pipeline by [writing it to proto and reading it
> back|https://github.com/apache/beam/blob/dce1eb83b8d5137c56ac58568820c24bd8fda526/sdks/python/apache_beam/runners/interactive/pipeline_fragment.py#L120].
> Reading it back fails because some of the pipeline is not written in Python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
