[ 
https://issues.apache.org/jira/browse/BEAM-12913?focusedWorklogId=653784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653784
 ]

ASF GitHub Bot logged work on BEAM-12913:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/21 19:55
            Start Date: 21/Sep/21 19:55
    Worklog Time Spent: 10m 
      Work Description: chunyang commented on a change in pull request #15536:
URL: https://github.com/apache/beam/pull/15536#discussion_r713372214



##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -1915,6 +1927,11 @@ class ReadFromBigQuery(PTransform):
         that dataset, and will remove it once it is not needed. Job needs 
access
         to create and delete tables within the given dataset. Dataset name
         should *not* start with the reserved prefix `beam_temp_dataset_`.
+    query_priority (BigQueryQueryPriority): By default, this transform runs

Review comment:
       This PR does make the priority BATCH by default.
   
   If you're asking about whether or not we should expose a `query_priority` 
parameter, I don't have strong opinions either way. My original commit 
(https://github.com/apache/beam/pull/15536/commits/b66e4b1361a6ccc0f5887777b0926630c7efc59e)
 makes it non-configurable, but after seeing that it's 
[configurable](https://beam.apache.org/releases/javadoc/2.32.0/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.TypedRead.html#withQueryPriority-org.apache.beam.sdk.io.gcp.bigquery.BigQueryIO.TypedRead.QueryPriority-)
 in the Java BigQueryIO, I decided to make the Python side consistent.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 653784)
    Time Spent: 1h 40m  (was: 1.5h)

> Enable configuring query priority in Python ReadFromBigQuery
> ------------------------------------------------------------
>
>                 Key: BEAM-12913
>                 URL: https://issues.apache.org/jira/browse/BEAM-12913
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-py-gcp
>    Affects Versions: 2.32.0
>            Reporter: Chun Yang
>            Assignee: Chun Yang
>            Priority: P3
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Submitting BigQuery queries with BATCH priority allows queries to be started 
> when idle resources are available and allows queries submitted from Beam to 
> not count toward a project's concurrent rate limit.
> The Java BigQueryIO enables configuring the query priority. We should enable 
> the same configuration in the Python ReadFromBigQuery.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to