[
https://issues.apache.org/jira/browse/BEAM-12931?focusedWorklogId=654283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654283
]
ASF GitHub Bot logged work on BEAM-12931:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Sep/21 22:39
Start Date: 22/Sep/21 22:39
Worklog Time Spent: 10m
Work Description: laraschmidt commented on a change in pull request
#15540:
URL: https://github.com/apache/beam/pull/15540#discussion_r714359098
##########
File path:
runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java
##########
@@ -386,6 +388,89 @@ public void testInfiniteSkew() {
BoundedWindow.TIMESTAMP_MAX_VALUE));
}
+ /**
+ * Demonstrates that attempting to set a timer with an output timestamp
before the timestamp of
+ * the current element with zero {@link DoFn#getAllowedTimestampSkew()
allowed timestamp skew}
+ * throws.
+ */
+ @Test
+ public void testTimerBackwardsInTimeNoSkew() {
Review comment:
I added ValidatesRunner tests for both the timer case and the normal
DoFn case as additional tests. Unit tests still make sense for this specific
DoFn and the validates runner ones cannot check for the exact error without
being overly restrictive. This seems like the wrong place for tests that
validate a runner but it seems like that's standard practice in beam so I just
put them here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 654283)
Time Spent: 20m (was: 10m)
> Timer.setOutputTimestamp doesn't take into account for
> DoFn#getAllowedTimestampSkew()
> -------------------------------------------------------------------------------------
>
> Key: BEAM-12931
> URL: https://issues.apache.org/jira/browse/BEAM-12931
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Lara Schmidt
> Assignee: Lara Schmidt
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> A DoFn may emit elements with a timestamp up to
> DoFn#getAllowedTimestampSkew() before the current element's timestamp.
> However getAllowedTimestampSkew is not properly accounted for in looking at
> the output timestamp of a timer.
> Context:
> [https://lists.apache.org/thread.html/r7554658114ddde86c5d82e1c39fe7e1ef587fe926b8e406d1130d501%40%3Cdev.beam.apache.org%3E]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
