[
https://issues.apache.org/jira/browse/BEAM-11985?focusedWorklogId=654625&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-654625
]
ASF GitHub Bot logged work on BEAM-11985:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/21 17:11
Start Date: 23/Sep/21 17:11
Worklog Time Spent: 10m
Work Description: ajamato commented on pull request #15562:
URL: https://github.com/apache/beam/pull/15562#issuecomment-926001201
> Hi, @ajamato would you help me to review this?
> I create a new class to override `flush` method in `MutationsBatcher` so I
can get the rows response of `table.mutate_rows`.
> Each row has a google.rpc.status_pb2.Status for some of these codes
https://cloud.google.com/bigtable/docs/status-codes is still missing how I can
handle the grpc status codes because service_call_metrics is expecting int
httpStatus or string status, but here the `grpc` status is an integer (0-14).
>
https://github.com/apache/beam/blob/82f08b4dabc923151683f69cde71372755c7227c/sdks/python/apache_beam/io/gcp/bigtableio.py#L124
Is there is a method on the status object to get the string status "ok",
"cancelled" "invalid_argument", etc. use that. (ServiceCallMetric will
lowercase it)
If there is only a way to obtain the numbers:
https://cloud.google.com/bigtable/docs/status-codes
0 (OK)
1 (CANCELLED)
2 (UNKNOWN)
...
Then please write a helper function to lookup the number from a map and
convert it to a string.
Lookup the string with that helper function before the call to
service_metric.call()
i.e.
grpc_status_string = convert_to_grpc_status_string(status.code())
service_metric.call(grpc_status_string)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 654625)
Time Spent: 3h 50m (was: 3h 40m)
> Python Bigtable - Implement IO Request Count metrics
> ----------------------------------------------------
>
> Key: BEAM-11985
> URL: https://issues.apache.org/jira/browse/BEAM-11985
> Project: Beam
> Issue Type: Test
> Components: io-py-gcp
> Reporter: Alex Amato
> Assignee: Benjamin Gonzalez
> Priority: P3
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
> Reference PRs (See BigQuery IO example) and detailed explanation of what's
> needed to instrument this IO with Request Count metrics is found in this
> handoff doc:
> [https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'|https://docs.google.com/document/d/1lrz2wE5Dl4zlUfPAenjXIQyleZvqevqoxhyE85aj4sc/edit'?authuser=0]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
