[
https://issues.apache.org/jira/browse/BEAM-6814?focusedWorklogId=212671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212671
]
ASF GitHub Bot logged work on BEAM-6814:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/19 20:43
Start Date: 13/Mar/19 20:43
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #8044: [BEAM-6814]
toRowList in BeamEnumerableConverter
URL: https://github.com/apache/beam/pull/8044#discussion_r265323006
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
##########
@@ -129,6 +140,11 @@ public static PipelineOptions
createPipelineOptions(Map<String, String> map) {
return options;
}
+ static List<Row> toRowList(PipelineOptions options, BeamRelNode node) {
+ // TODO: support limit.
Review comment:
@apilloud Thanks! Comment addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 212671)
Time Spent: 1h 40m (was: 1.5h)
> BeamEnumerableConverter returns a list of Row
> ----------------------------------------------
>
> Key: BEAM-6814
> URL: https://issues.apache.org/jira/browse/BEAM-6814
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Right now BeamEnumerableConverter returns Enumerable<Object>, we can provide
> alternative option to return a list of Row.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
