[
https://issues.apache.org/jira/browse/BEAM-12795?focusedWorklogId=655312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655312
]
ASF GitHub Bot logged work on BEAM-12795:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/21 20:25
Start Date: 26/Sep/21 20:25
Worklog Time Spent: 10m
Work Description: reuvenlax commented on a change in pull request #15465:
URL: https://github.com/apache/beam/pull/15465#discussion_r716256510
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/ParDoEvaluator.java
##########
@@ -100,7 +101,8 @@
windowingStrategy,
doFnSchemaInformation,
sideInputMapping);
- if (DoFnSignatures.signatureForDoFn(fn).usesState()) {
+ DoFnSignature signature = DoFnSignatures.signatureForDoFn(fn);
+ if (signature.usesState() || signature.onWindowExpiration() != null) {
Review comment:
Yes, though it could also be separated. OnWindowExpiration didn't work
if there were no state variables, which caused some of the tests I added to
fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 655312)
Time Spent: 1h 40m (was: 1.5h)
> KVs should not be needed when using schemas
> -------------------------------------------
>
> Key: BEAM-12795
> URL: https://issues.apache.org/jira/browse/BEAM-12795
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Reuven Lax
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> When using schemas there should be no need to require a KV, as any. key or
> keys can be act as the K or a V in a KV. Users can use schemas without the
> need for KV in all cases except for state/timers DoFns, which today require
> that the input have type KV. We would like to eliminate this requirement.
> Users should be able to specify a key field extraction in their ParDo, e.g.
> ParDo.of(...).withKeyFields("user.location.city"));
> Or in the DoFn itself.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
