[
https://issues.apache.org/jira/browse/BEAM-11217?focusedWorklogId=655953&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655953
]
ASF GitHub Bot logged work on BEAM-11217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/21 02:48
Start Date: 28/Sep/21 02:48
Worklog Time Spent: 10m
Work Description: lostluck commented on a change in pull request #15482:
URL: https://github.com/apache/beam/pull/15482#discussion_r717174187
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -529,6 +561,21 @@ func (r CounterResult) Result() int64 {
return r.Attempted
}
+// Name returns the Name value from the Key field.
+func (r CounterResult) Name() string {
+ return r.Key.Name
+}
+
+// Namespace returns the Namespace value from the Key field.
Review comment:
```suggestion
// Namespace returns the Namespace of this Counter.
```
and similar for Gauge and Distribution
##########
File path: sdks/go/pkg/beam/core/metrics/metrics.go
##########
@@ -529,6 +561,21 @@ func (r CounterResult) Result() int64 {
return r.Attempted
}
+// Name returns the Name value from the Key field.
Review comment:
```suggestion
// Name returns the Name of this Counter.
```
and similar for Gauge and Distribution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 655953)
Time Spent: 5h 20m (was: 5h 10m)
> Implement metrics filtering
> ---------------------------
>
> Key: BEAM-11217
> URL: https://issues.apache.org/jira/browse/BEAM-11217
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Kamil Wasilewski
> Assignee: Ritesh Ghorse
> Priority: P3
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> `metrics.Results` misses a method for querying metrics using a provided
> filter. The method should take a filter object as an argument and return
> `metrics.QueryResults` object containing metrics that matched the filter.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
