[
https://issues.apache.org/jira/browse/BEAM-12973?focusedWorklogId=655973&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655973
]
ASF GitHub Bot logged work on BEAM-12973:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/21 04:34
Start Date: 28/Sep/21 04:34
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #15604:
URL: https://github.com/apache/beam/pull/15604#discussion_r717215390
##########
File path: sdks/go/test/run_validatesrunner_tests.sh
##########
@@ -70,7 +70,8 @@
# jar from the appropriate gradle module, which may not succeed.
set -e
-set -v
+trap '! [[ "$BASH_COMMAND" =~ ^(echo|read|if|ARGS|shift|SOCKET_SCRIPT|\[\[) ]]
&& \
Review comment:
Minor nit: A comment explaining what this line is doing would be useful,
since it's pretty incomprehensible to the average reader.
(It just prints all commands executed to stdout except for the lines
starting with one of those commands specified up top, right? I'm guessing the
"eval echo" bit is some safety checks?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 655973)
Time Spent: 40m (was: 0.5h)
> Improve debug printouts of GoSDK gradle Integration script
> ----------------------------------------------------------
>
> Key: BEAM-12973
> URL: https://issues.apache.org/jira/browse/BEAM-12973
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go, testing
> Reporter: Robert Burke
> Assignee: Robert Burke
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The script currently doesn't output echos and similar reliably when run
> either as a gradle command (it's primary usage) or on jenkins, making testing
> a bit trickier, as the debug echos are swallowed. Test case, and
> configuration should be be output and visible in the jenkin's console outputs
> to ease debugging and failure analysis.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
