[
https://issues.apache.org/jira/browse/BEAM-12607?focusedWorklogId=656996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656996
]
ASF GitHub Bot logged work on BEAM-12607:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/21 03:42
Start Date: 29/Sep/21 03:42
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #15611:
URL: https://github.com/apache/beam/pull/15611#discussion_r718129111
##########
File path: website/www/site/static/js/copy-to-clipboard.js
##########
@@ -13,15 +13,15 @@
$(document).ready(function() {
function copy() {
$(".copy").click(function(){
- var
text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerHTML;
+ var
text=$(this).siblings()[$(this).siblings().length-1].childNodes[0].innerText;
const el=document.createElement('textarea');
el.value=text;document.body.appendChild(el);
el.select();document.execCommand('copy');
document.body.removeChild(el);
alert('copied to clipboard');
Review comment:
same for the alert on line 29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 656996)
Time Spent: 0.5h (was: 20m)
> Copy Code Snippet copies html tags
> ----------------------------------
>
> Key: BEAM-12607
> URL: https://issues.apache.org/jira/browse/BEAM-12607
> Project: Beam
> Issue Type: Bug
> Components: website
> Reporter: Ahmet Altay
> Assignee: Fernando Morales
> Priority: P1
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> User reported issue:
> https://lists.apache.org/thread.html/r92358426aa181b9b128c838e8f29c66fffd55ef571f8fa66d87dbf72%40%3Cdev.beam.apache.org%3E
> """
> I was poking around this page on my Mac running Big Sur 11.4 and using the
> latest version of Chrome:
> https://beam.apache.org/documentation/runners/dataflow/
> And hitting the "copy to clipboard" button copies the snippet with all the
> html formatting.
> Happened on Firefox as well.
> """
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
